Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,android: Added option to compile for Android with -fPIE flag #5783

Closed
wants to merge 1 commit into from
Closed

build,android: Added option to compile for Android with -fPIE flag #5783

wants to merge 1 commit into from

Conversation

bsegault
Copy link

Description of change

Hi,

Node for Android wasn't executable using the actual android-configure file. I made this PR using @kikijhu proposition and it builds fine on Linux (see #3581).

The created executable is PIE, and thus working on Android L & M (both tested).

I welcome any improvement you can make to this PR.

@mscdex mscdex added build Issues and PRs related to build files or the CI. arm Issues and PRs related to the ARM platform. labels Mar 18, 2016
@mscdex
Copy link
Contributor

mscdex commented Mar 18, 2016

I think you linked to the wrong issue?

Also is the addition of --without-snapshot necessary?

@WebReflection
Copy link
Contributor

FYI: as author of the linked issue, I can confirm that has nothing to do with this PR.

@bsegault
Copy link
Author

Hum, sorry for the wrong issue mention... Dunno what happened; first post updated.
@mscdex --without-snapshot allowed me to complete the build. I get a weird syntax error on a ) when I ommit it. Will post a log output for this error next monday if you want.

@kikijhu
Copy link

kikijhu commented Mar 21, 2016

@mscdex as @bsegault said, if use --with-snapshot, we can't build pass for Android.

Here is the build log.

/home/kiki/node.js/node-v5.4.1/out/Release/mksnapshot: 1: /home/kiki/node.js/node-v5.4.1/out/Release/mksnapshot: Syntax error: word unexpected (expecting ")")
make[1]: *** [/home/kiki/node.js/node-v5.4.1/out/Release/obj.target/v8_snapshot/geni/snapshot.cc] Error 2
make[1]: Leaving directory `/home/kiki/node.js/node-v5.4.1/out'
make: *** [node] Error 2

@rvagg
Copy link
Member

rvagg commented Mar 22, 2016

I'm seeking some feedback about how Node.js is used on Android if anyone watching this thread would like to tell us about it: nodejs/build#359

@estliberitas estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23
@bnoordhuis
Copy link
Member

Closing, obsoleted by #5544 which landed in commit 271201f. We're building with -fPIE -fpie now so this should be working.

@bnoordhuis bnoordhuis closed this May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bsegault @mscdex @WebReflection @kikijhu @rvagg @bnoordhuis